matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.68k stars 2.62k forks source link

Ensure grouping a dimension in ms doesn't fail if ranking query limit is reached #22580

Closed sgiehl closed 1 week ago

sgiehl commented 1 week ago

Description:

When grouping dimension values it might happen that a ranking query already limited the amount of records. In that case a row with value __mtm_ranking_query_others__ will occur.

This currently fails for dimensions in milliseconds, as calculating with the __mtm_ranking_query_others__ value doesn't work.

This PR ensures that only numeric values are taken into account for that calculation.

fixes #22579

Review