Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
The implementation of #22535 moved the detection of the current transaction level to traits.
During this migration a typo slipped through, breaking the fallback from @@TX_ISOLATION to @@transaction_isolation because PHP happily ignores any catch statement for classes that don't exist.
MySQL 5.7 and MariaDB latest (the database versions running in CI) both provide the @@TX_ISOLATION system variable, so tests were successful
MySQL 8.0 does NOT provide that variable, triggering the fallback that was then skipped due to a typo in the catch clause.
[ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
[ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
Description:
The implementation of #22535 moved the detection of the current transaction level to traits.
During this migration a typo slipped through, breaking the fallback from
@@TX_ISOLATIONto@@transaction_isolationbecause PHP happily ignores any catch statement for classes that don't exist.MySQL 5.7andMariaDB latest(the database versions running in CI) both provide the@@TX_ISOLATIONsystem variable, so tests were successfulMySQL 8.0does NOT provide that variable, triggering the fallback that was then skipped due to a typo in thecatchclause.Review