Closed sgiehl closed 1 month ago
Did you use a tool to convert the params or did you do it manually?
@michalkleiner I actually used a regex to find those and fixed them manually. Might be possible that I missed some though. But I didn't want to introduce new type hints on purpose and only fixed those that had an implicit nullable value.
implicit nullable value.
Implicit nullable typed value. Fair enough.
Description:
With PHP 8.4 implicitly marking parameters as nullable by only setting null as default value is deprecated. To get rid of all the deprecation notices caused by our code, this PR aims to change all occurrences to explicitly mark the parameters as nullable.
refs #22471
Review