Add default message when report documentation is not available

[ilacftemp]

Description:

This change addresses the issue where the report documentation appears odd or empty when no documentation is available for a report. Specifically, it ensures that a default message ("No documentation available for this report.") is displayed when reportDocumentation is empty or missing. This improves the user experience by providing clear feedback instead of showing a blank or incomplete UI.

Review

• [ ] Functional review done
• [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• [ ] Security review done
• [ ] Wording review done
• [ ] Code review done
• [ ] Tests were added if useful/possible
• [ ] Reviewed for breaking changes
• [ ] Developer changelog updated if needed
• [ ] Documentation added if needed
• [ ] Existing documentation updated if needed

[ilacftemp]

I corrected what you asked for! Thanks for the help @michalkleiner! Could you review this PR again, please?

[michalkleiner]

Fixes #12928

[ilacftemp]

Lint errors corrected! :)

[ilacftemp]

Hi @michalkleiner ! Anything else to correct?

[ilacftemp]

Hey @michalkleiner , I'm sorry for bothering you, but are there any more changes to be made? If there are, I'll work on them right away, otherwise, could you merge this? Thank you so more for your time!

[sgiehl]

I'm personally not sure if adding that default text brings any benefits.

If a documentation is set for such a evolution graph and info icon will be shown on hover:

Clicking it will show the documentation text:

So adding a default documentation would cause that the info icon would be shown for every evolution report. Even if no real documentation is available. Clicking on it would then only show the default text, which does not have any additional value for the user.

@ronak-innocraft Do you think adding such a default text would bring any benefits or should we keep the behavior as it is?

[ronak-innocraft]

@ronak-innocraft Do you think adding such a default text would bring any benefits or should we keep the behavior as it is? @sgiehl If there is no useful info that can help user to understand the report than I don't think it makes sense to show help icon by default unless there is targeted help info defined per report.

[sgiehl]

Hey @ilacftemp. Thanks for putting time and effort into creating this pull request.

As @ronak-innocraft explained, adding this default documentation would not bring any benefit to our users. Therefor we will close this PR unmerged.

If you plan to work on any further change, please consider checking if there is an existing issue for it, so you can comment it or create a new issue for it. That way you are able to get some feedback from our side, if we would consider merging a certain change, before you invest further time on it.

Thanks for your understanding.