Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
When testing #22718 in a different environment, my geolocation setup was incomplete. The provider was configured, but the database was missing.
This resulted in a broken login process because LocationProvider::getCurrentProvider() returned a null.
I also changed the check for supported location info to prevent a potential "Undefined index: country_code" warning. With the GeoIp2 provider this could happen if there is only an ISP database available, but no "regular" database.
[ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
[ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
Description:
When testing #22718 in a different environment, my geolocation setup was incomplete. The provider was configured, but the database was missing.
This resulted in a broken login process because
LocationProvider::getCurrentProvider()returned anull.I also changed the check for supported location info to prevent a potential "Undefined index: country_code" warning. With the GeoIp2 provider this could happen if there is only an ISP database available, but no "regular" database.
Review