[Bug] When deleting currently selected site, and you delete that site, an error shows up

[tsteur]

What happened?

An error shows up and you can't use Matomo anymore when you delete the currently selected site. When you try to go back every previous page will show an error too because the site has been deleted.

What should happen?

When you delete the currently selected site, Matomo should change the idSite parameter in the URL to a valid idSite so that measurable management works again.

How can this be reproduced?

• Select any site in Matomo
• Go to Admin -> Measurables -> Manage
• Delete the selected site
• An error shows up and you can't use Matomo anymore. When you try to go back every previous page will show an error too because the site has been deleted.
• You need to enter your Matomo domain to continue working

Matomo version

5

PHP version

No response

Server operating system

No response

What browsers are you seeing the problem on?

No response

Computer operating system

No response

Relevant log output

No response

Validations

• [X] Read our Contributing Guidelines.
• [X] Follow our Security Policy.
• [X] Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
• [X] The provided steps to reproduce is a minimal reproducible of the Bug.

[michalkleiner]

Hi Thomas, thanks for the report. Looking at the expected behaviour you're suggesting, would it possibly be better if parts of the admin interface that don't need to know about an active site didn't rely on having one in the URL at all? If we went with the approach of changing to a valid site id, which site id should it select? The oldest one, the newest one, the one with most revenue, some other one?

[sgiehl]

@michalkleiner Some parts of the admin do not need an idsite set. But if there is none, and you then switch to a part, where one would be needed, a similar problem occurs. So introducing some sort of default / fallback in case none is provided might be good.