Open julienmoumne opened 12 years ago
We could propose this feature enabled by default, the favicon would be http fetched and cached in tmp/assets/favicon/ for example, refreshed once per week, displayed in All Websites (instead of the outgoing orange icon), and in the Static Evolution Graphs. It that will increase piwik reports look and ease the analysis. Great idea.
We could use:
To get the favicon for any site? and cache the favicon locally in Piwik..
This would have some "privacy" concerns because then the website getfavicon.appspot would know that the user is related to the requested websites. Alternatively, Piwik could http fetch the favicon automatically (but it requires to parse the homepage then query the favicon which is more complicated and painful).
So I would say
https://github.com/piwik/piwik/issues/10016 gives some more/other details to setup and usage of favicons
hmm -why is there an external service needed to fetch favicon if we have the url?
would vote for finding a solution to make favicon fetching (e.g. Button click, see #10016) & showing without any privacy concerns and with this enabled by default. -> would enchance usability and look a lot
hmm -why is there an external service needed to fetch favicon if we have the url?
I reckon because there could be different favicon (ico, png, ...) and via HTML you can even define a custom path so we'd need to parse HTML under circumstances to find correct favicon etc. I presume that was the thought behind using a service for it. A basic version could be implemented without external service though I presume.
The favicon would be displayed wherever applicable such as :
as @hpvd mentioned in #10016 could be also shown in website selector etc.
+1 for basic version without any external tool (first step) after that we could thing again of how to make next step...
extracted from #10016 Show website's favicon in website selector + on other places with website-name
Showing website's favicon in website selector would give selecting website better usability and a more individual "here I'm home"(-> I see my websites favicon) look. Show
please see attachment
Maybe this could be simply fetched and stored during site setup on Administration/Websites/Manage websites when clicking save button (plus always refetch the latest version on every click of this button)
from comment in #10016: of course this favicon could not be only shown in website selctor, but also on all places where website name is mentioned... e.g. Administration/Websites/
from comment in #10016: if one would make it even more universal, one could provide on Administration/Websites/Manage websites 2 Buttons/function:
(instead of coupeling with save-button as proposed above)
@mattab , @tsteur
just had a look at github and serached for "favicon" https://github.com/search?utf8=%E2%9C%93&q=favicon
=> there seem to be many solutions available without any "external service" need to fetch favicon... (so there is no need to start with only a basic integration of this)
Yeah that's probably a better idea to use a lib and not to rely on an external service for this re privacy and any external service might also not exist forever :+1:
In Websites Management, allow user to specify a favicon for the website.
Include the uploaded favicon, if available, in report metadata <logo/> markup.
The favicon would be displayed wherever applicable such as :