QA: run Javascript tests on both the original and minified JS

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!

https://matomo.org/

GNU General Public License v3.0

19.67k stars 2.62k forks source link

QA: run Javascript tests on both the original and minified JS #5165

Open mattab opened 10 years ago

mattab commented 10 years ago

Use case: as a Piwik core developer, I make changes to js/piwik.js. I forget to compile/minify the Javascript as per instructions in: https://github.com/piwik/piwik/tree/master/js#introduction

Got: mismatch between js/piwik.js and piwik.js. Javascript tests still pass (because they run on js/piwik.js)

Expected: Javascript tests should have failed.

Alternative solution:

Unit test that runs the minifier to check that the piwik.js is the same as minified js/piwik.js

tsteur commented 10 years ago

In 9c71faa44317fe1fc538cc785477d5913bf4302f: refs #5165 this is not directly related but can prevent forgetting to minify piwik.js. Whenever js/piwik.js is updated grunt will automatically minify/compile it instantly