search

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.68k stars 2.62k forks source link

users with "view" access should see the link to display the javascript code for their sites #554

Closed mattab closed 10 years ago

mattab commented 15 years ago

Users with a "view" permission should see the table with the website information and the "Show Javascript" link, the same way "admin" users currently see the table.

For users with "view", the website table wouldn't be editable.

see also #526

anonymous-matomo-user commented 14 years ago

Attachment: patch#554.txt

anonymous-matomo-user commented 14 years ago

Attachment: Icon js.gif

anonymous-matomo-user commented 14 years ago

Attachment: MultiSite-extended.png

robocoder commented 14 years ago

Moving this to 0.6. Access to #42 ("exclude visits by cookie") should be incorporated into the SitesManager UI.

anonymous-matomo-user commented 14 years ago

I extended the MultiSites-Controller table by a new Icon, linked to the javascript code of the site. For displaying the javascrit code, i utilize the existing SitesManager module. For non-Admin user i disable the SitesManager-Navigation. See attached Screenshot and patch.

Would this an adequate solution for this ticket?

mattab commented 14 years ago

Sophie, I think it would be better to have the javascript displayed in the "website" tab for "view" users, after clicking "settings" in the top bar (available in trunk for "view" users)

anonymous-matomo-user commented 14 years ago

Ok, i see.

So it's changing #526: "- for user with 'view', only show the "My Profile" tab" to "- for user with 'view', show the "My Profile" and "Websites" tab". Right?

There are two further questions for me:

1. For the view-only user the table's content it's clear: "For users with "view", the website table wouldn't be editable." But I can't find anything about the editing by an admin user. Currently it's behaving strange (Edit is clickable, just site name is changeable, but changes can't be saved). How should the table editing/deleting behave for an admin user?

2. I assume: For multi sites a user can have view access to one site as well as admin access to another site. Am i right? If yes: Should view and admin sites mixed into one table? Or do you like to provide seperate tables? Shurely it depends whether the interaction of view and admin user will be different or not. If not, the sites could simply shown in one table.

mattab commented 14 years ago

I think that it could be like:

If the edit website screen does not work for you, it is a bug in Piwik. It works for us in 0.5.5 and 0.6-rc1 (edit name / URLs / etc. and click the green button to update).

There is no difference in how view or admin websites are handled in all the web analytics reports: they behave exactly the same.

mattab commented 10 years ago

Currently as of Piwik 2.0 the Tracking Code page is listed when the user has at least Admin permission to one website. Seems right.