search

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.84k stars 2.64k forks source link

Pivotting a report w/ all columns or goals view is broken #7506

Open diosmosis opened 9 years ago

diosmosis commented 9 years ago

If a report is viewed in the All Columns view or the Goals view, and the table is pivotted, the result is incorrect (w/ no data being displayed).

The pivoting itself appears to work (although the resulting datatable is missing the numeral prefixes, which may be expected, I'm not sure). After the pivoting the DataTablePostProcessor::$callbackBeforeGenericFilters function is called which erases all data in the table. The closure that removes the rows is here: https://github.com/piwik/piwik/blob/master/core/Plugin/Visualization.php#L400

mattab commented 9 years ago

If a report is viewed in the All Columns view or the Goals view, and the table is pivotted

Maybe we could improve the Pivot feature and display a Metric selector, that would let user select the metric being pivotted. User could choose between Actions, Actions per visit, Average time on site, Goal 1 Conv rate, etc.

If we don't show the metric selector, then we could just for now "disable" the pivot feature when "All columns" or "Goals" view is selected for a datatable?

diosmosis commented 9 years ago

I think this is a good idea, but I think it's unrelated to the failure.

mattab commented 9 years ago

so as first step and scope of this issue: let's simply disable this view so the bug cannot be triggered ie. "disable" the pivot feature when "All columns" or "Goals" view is selected (we would re-investigate later when working on #4776 )