matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.85k stars 2.64k forks source link

Flash Widgets - "loading-blue.gif" never finishes #795

Closed anonymous-matomo-user closed 15 years ago

anonymous-matomo-user commented 15 years ago

I've copied and pasted the Flash widget from piwik.org and changed the

<param value="always" name="allowScriptAccess">

to prevent cross site scripting blocking in flash.

<object style="visibility: visible;" id="UserCountrygetContinentChart_swf" data="http://piwik.org/demo/libs/open-flash-chart/open-flash-chart.swf?v2i" bgcolor="#FFFFFF" type="application/x-shockwave-flash" width="100%" height="250">
  <param value="always" name="allowScriptAccess">
  <param value="opaque" name="wmode">
  <param value="data-file=http%3A%2F%2Fpiwik.org%2Fdemo%2Findex.php%3Fmodule%3DUserCountry%26action%3DgetContinent%26idSite%3D1%26period%3Dday%26date%3D2009-06-12%26filter_sort_column%3Dnb_uniq_visitors%26filter_sort_order%3Ddesc%26viewDataTable%3DgenerateDataChartVerticalBar&loading=Laden..." name="flashvars">
</object>
<div id="dataTableFeatures">
  <div> 
    <span id="dataTableFooterIcons"> 
      <span id="exportToFormat" style="display: none; padding-left: 4px;"> 
        <span id="dataTableFooterExportAsImageIcon"> <a href="javascript:OFC.jquery.popup('UserCountrygetContinentChart_swf');"><img title="Als Bild exportieren" src="http://piwik.org/demo/themes/default/images/image.png"></a></span> 
        <img src="http://piwik.org/demo/themes/default/images/export.png" title="Export" width="16" height="16"> 
        <span id="linksExportToFormat" style="display: none;">  
          <a href="http://piwik.org/demo/?module=API&method=UserCountry.getContinent&format=CSV&idSite=1&period=day&date=2009-06-12&token_auth=anonymous&filter_limit=100" target="_blank" class="exportToFormat" methodtocall="UserCountry.getContinent" format="CSV" filter_limit="100">CSV</a> |  
          <a href="http://piwik.org/demo/?module=API&method=UserCountry.getContinent&format=XML&idSite=1&period=day&date=2009-06-12&token_auth=anonymous&filter_limit=100" target="_blank" class="exportToFormat" methodtocall="UserCountry.getContinent" format="XML" filter_limit="100">XML</a> | 
          <a href="http://piwik.org/demo/?module=API&method=UserCountry.getContinent&format=JSON&idSite=1&period=day&date=2009-06-12&token_auth=anonymous&filter_limit=100" target="_blank" class="exportToFormat" methodtocall="UserCountry.getContinent" format="JSON" filter_limit="100">Json</a> | 
          <a href="http://piwik.org/demo/?module=API&method=UserCountry.getContinent&format=PHP&idSite=1&period=day&date=2009-06-12&token_auth=anonymous&filter_limit=100" target="_blank" class="exportToFormat" methodtocall="UserCountry.getContinent" format="PHP" filter_limit="100">Php</a> |  
          <a href="http://piwik.org/demo/?module=API&method=UserCountry.getContinent&format=RSS&idSite=1&period=day&date=last10&token_auth=anonymous&filter_limit=100" target="_blank" class="exportToFormat" methodtocall="UserCountry.getContinent" format="RSS" filter_limit="100" date="last10"><img src="http://piwik.org/demo/themes/default/images/feed.png" border="0"></a> 
        </span>
        <a class="viewDataTable" format="cloud"><img src="http://piwik.org/demo/themes/default/images/tagcloud.png" title="Schlagwortwolke" width="16" height="16"></a> 
        <a class="viewDataTable" format="graphVerticalBar"><img src="http://piwik.org/demo/themes/default/images/chart_bar.png" title="Sulendiagramm" width="16" height="16"></a> 
        <a class="viewDataTable" format="graphPie"><img src="http://piwik.org/demo/themes/default/images/chart_pie.png" title="Kreisdiagramm" width="16" height="16"></a> 
      </span> 
      <span id="dataTableFooterIconsShow" style="padding-left: 4px;"> <img src="http://piwik.org/demo/plugins/CoreHome/templates/images/more.png"> </span> 
      <span id="tableAllColumnsSwitch" style="border-right: 1px solid rgb(130, 161, 210); float: right; padding-right: 4px;"> <img title="Normale Tabelle anzeigen" src="http://piwik.org/demo/themes/default/images/table.png"> </span> 
      <span id="tableGoals" style="float: right; padding-right: 4px;"> <img title="View Goals" src="http://piwik.org/demo/themes/default/images/goal.png"> </span> 
    </span> 
  </div> 
  <span id="loadingDataTable"><img src="http://piwik.org/demo/themes/default/images/loading-blue.gif"> Lade Daten...</span> 
</div>
<div class="dataTableSpacer"></div>

But I get the below error in the Firebug console. It's German...

Die Erlaubnis fr den Aufruf der Methode Location.toString wurde verweigert
Line 0

English should be something like:

Access denied calling method Location.toString
Line 0
anonymous-matomo-user commented 15 years ago

Attachment: Screenshot piwik_flash_widget_bug1.png

anonymous-matomo-user commented 15 years ago

Aside OFC.jquery.popup() seems useless if I do not have the JS files.

robocoder commented 15 years ago

When we used OFC1, we didn't export the dataTableFeatures div. The quick fix is to remove this footer as it depends on undocumented additional scripts, javascript that isn't present in an external .js file, etc.

mattab commented 15 years ago

there must be a bug around: https://github.com/piwik/piwik/blob/master/plugins/Widgetize/templates/widgetize.js#L71

the "flash" export of the widget should only give back the "object" tag and not the footer. if anyone wants to have a look please do so :)

robocoder commented 15 years ago

(In [1239]) fixes #795 - just the flash content