Config.ini.php shouldn't affect test enviornament.

[sebastianpiskorski]

If I set some value in config.ini.php

[MySection]
key = value

running any test I get:

$config = Config::getInstance();
var_dump($config->MySection);
//Output:
array(1) {
  'key' =>
  string(5) "value"
}

it shouldn't be visible from tests, shouldn't be set implicitly in environment. Tests should use only global.ini.php, and explicit TestConfig class.

Why is this bad?

• One config might affect many places and many tests, thus test can give fake results.
• Every test should be isolated as much as possible, especially from local instance settings.
• Every test should set its own Config, so it is possible to test many various cases. Config values might exclude some scenarios. Eg. If you have set config for scenario A it might affect scenario B and give fake result.
• There might be a test that will have to physically write to config. If value will stay in config it might break some other tests.

[mattab]

:+1: absolutely agree. Our tests shouldn't depend on the local configuration file. a pull request would be very welcome, or we will investigate in coming months / during 3.0.0 dev cycle