Fix: GetCustomVariable - Invalid result for Visit and Event scoped custom variableGetCustomVariables

matomo-org / piwik-dotnet-tracker

C# API client SDK for the Piwik Tracking API

BSD 3-Clause "New" or "Revised" License

74 stars 47 forks source link

Fix: GetCustomVariable - Invalid result for Visit and Event scoped custom variableGetCustomVariables #40

Closed ptr1120 closed 7 years ago

ptr1120 commented 7 years ago

In order to fix #37:

added test project with NUnit
added test for GetCustomVariable()
implemented fix for #37
fixed issue introduced in commit 4141d695a8f3e6625ab06478bfef59b21c5e52de (wrong variable test in constructor)

julienmoumne commented 7 years ago

Hi Peter, thanks for submitting the first automated test.

I am having difficulties building the project, can you have a look at this screen shot :

Don't you have the same error on your IDE? If not, is there something I need to configure on my machine?

Also, I forgot to catch this before, wouldn't it be nicer to move PiwikTracker.DebugLastRequestedUrl to TrackingResponse.url ?

Except for these two comments it looks good!

ptr1120 commented 7 years ago

Hi Julien,

sorry for the issue with DebugLastRequestUrl, I did not see the compilation error after making this property as instance variable in commit 99860e7638fe749f4dd39c155505fdcec6fae8c1. I also think it would be useful to have the DebugLastRequestUrl as property RequestUrl in the TrackingResponse. Should I add a fix to this PR or is it better to add a new PR?

julienmoumne commented 7 years ago

No worries, we'll soon have travis checking-out these bugs!

Same PR is fine, thanks.

ptr1120 commented 7 years ago

Appending of commits isn't possible because my fork differs. Please merge this PR first.