Fix DoTrackAction with ActionType.Download is not tracked as a download - Githubissues

matomo-org / piwik-dotnet-tracker

C# API client SDK for the Piwik Tracking API

BSD 3-Clause "New" or "Revised" License

74 stars 47 forks source link

Fix DoTrackAction with ActionType.Download is not tracked as a download #71

Open MERamadan opened 5 years ago

MERamadan commented 5 years ago

Fix for issue #68 Issue: When posting a download action with query parameter Downalod (capital D), it is tracked as a page view instead of download action.

More Details: https://github.com/matomo-org/matomo/issues/14396 https://github.com/matomo-org/matomo/issues/10534

Notes: (1) Changes in PiwikTrackerSamples are:

Change TrackDownload to set the url too, which is recommended by Matomo documentation.

(2) Changes in PiwikTracker are:

fix GetUrlTrackAction to set the actionType with lower case
change SendRequest, so in case of similar bugs or matomo added a new url parameters and it are not added yet to the .net client, users can get the url (i.e. using GetUrlTrackAction) and use SendRequest to post it to Matomo.