matomo-org / piwik-python-api

Piwik API for Python
BSD 3-Clause "New" or "Revised" License
101 stars 43 forks source link

Improve testing method #6

Closed halfdan closed 11 years ago

halfdan commented 11 years ago

I think its common practice for Python projects to execute tests by calling python setup.py test, this was not possible before so I implemented this. Not sure if some lines in base.py are unnecessary now, so you might want to check that.

It would be great to add automatic test builds using Travis-CI to this project. If you like I can work on a solution to get a running Piwik installation onto the Travis-CI server so we can automatically test the library each time a commit happens.

Changes:

nkuttler commented 11 years ago

Thanks Fabian, just fixed it with a slightly modified commit.

halfdan commented 11 years ago

Any reason why you don't want python setup.py test to work? Afaik this is common practice for Python projects..

nkuttler commented 11 years ago

I closed the pull request because this issue is fixed. Thanks for your patch, but I chose a different approach.

halfdan commented 11 years ago

That is completely fine - just curious why :)