Add possibility to disable anonymization for self Piwik, and track User ID

matomo-org / plugin-AnonymousPiwikUsageMeasurement

Help making Matomo better by sending anonymized usage data to the creators the project, and/or to your own Matomo instance and/or to any other Matomo instance

https://plugins.matomo.org/AnonymousPiwikUsageMeasurement

GNU General Public License v3.0

4 stars 12 forks source link

Add possibility to disable anonymization for self Piwik, and track User ID #27

Closed andrzejewsky closed 8 years ago

andrzejewsky commented 8 years ago

Issue: https://github.com/piwik/plugin-AnonymousPiwikUsageMeasurement/issues/25

andrzejewsky commented 8 years ago

@tsteur You have done code review before I finished.. but of course many thanks! :+1:

I introduced your comments, but I have one question.. How can I run these tests: https://github.com/piwik/plugin-AnonymousPiwikUsageMeasurement/tree/master/javascripts (*.spec.js files)? I would like to update it.

tsteur commented 8 years ago

Yeah sorry. I had to review so many PRs and just went over all of them :)

Re how to test them see: https://github.com/piwik/piwik/tree/master/tests/angularjs I hope the docs there are kinda complete and it works. Feel free to ping me if not and we can adjust docs if needed

andrzejewsky commented 8 years ago

@tsteur thanks for help. I added js tests

andrzejewsky commented 8 years ago

@tsteur updated. Unfortunately, I don't know why Travis fails? Yesterday everything was ok

tsteur commented 8 years ago

It's very weird re the tests. It is running the tests against Piwik 2.15.1-b1 (see https://travis-ci.org/piwik/plugin-AnonymousPiwikUsageMeasurement/jobs/102046612#L207-L230) but fails because of a change that was made recently in Piwik master and will be included in Piwik 2.16.0-b2.

Update: Actually this commit broke it https://github.com/piwik/plugin-AnonymousPiwikUsageMeasurement/commit/05b1e6237b68f2177e6801e2a66f6fee7b64f980 so simply ignore it for now. I will change the target Piwik version later

tsteur commented 8 years ago

Created https://github.com/piwik/plugin-AnonymousPiwikUsageMeasurement/issues/28 to not forget, it is because of a "breaking" API change in Piwik core and the tests were made to succeed in Piwik master but now they fail here...

tsteur commented 8 years ago

Tests will probably succeed next time they run

andrzejewsky commented 8 years ago

@tsteur yes, now tests passed!

tsteur commented 8 years ago

Just tested it manually. LGTM :+1:

mattab commented 8 years ago

@andrzejewsky issue #25 is about measuring the "User Id" - I don't think this PR will close #25 but it is a nice feature anyway :+1:

Proposal:

When Anonimyse tracking requests is un-checked, then we can automatically track the username as a "User ID" (in self+ custom piwik)

mattab commented 8 years ago

Add the new feature in the Changelog https://github.com/piwik/plugin-AnonymousPiwikUsageMeasurement/blob/master/README.md#changelog