matomo-org / plugin-AnonymousPiwikUsageMeasurement

Help making Matomo better by sending anonymized usage data to the creators the project, and/or to your own Matomo instance and/or to any other Matomo instance
https://plugins.matomo.org/AnonymousPiwikUsageMeasurement
GNU General Public License v3.0
4 stars 12 forks source link

[Vue] Remove AngularJS uses from tracking.js #70

Closed diosmosis closed 2 years ago

diosmosis commented 2 years ago

Description:

This PR depends on https://github.com/matomo-org/matomo/pull/19348.

Changes:

Review

diosmosis commented 2 years ago

@sgiehl can this be merged?

sgiehl commented 2 years ago

Just looking at the code, the changes look good to me. But I have actually never used or worked with the plugin. So it would take me a lot time to get familiar with it in the first place, for being able to prove that it still does the same as before. Unfortunately I don't have the time for doing that at the moment. Not sure if @AltamashShaikh is familiar with the plugin and can take over here.