matomo-org / plugin-AnonymousPiwikUsageMeasurement

Help making Matomo better by sending anonymized usage data to the creators the project, and/or to your own Matomo instance and/or to any other Matomo instance
https://plugins.matomo.org/AnonymousPiwikUsageMeasurement
GNU General Public License v3.0
4 stars 12 forks source link

update expected test file for #20592 in matomo core #78

Closed diosmosis closed 1 year ago

diosmosis commented 1 year ago

Description:

Depends on https://github.com/matomo-org/matomo/pull/20592

As title.

Review

snake14 commented 1 year ago

@diosmosis Why is this change necessary? The builds are currently passing on 4.x-dev.

diosmosis commented 1 year ago

@snake14 its to fix the build if/when matomo-org/matomo#20592 is merged. It's a preemptive build fix. (which is therea no needs review label)

snake14 commented 1 year ago

@diosmosis It looks like the core PR didn't get merged. Should this PR be closed? We're trying to create beta releases for the plugins and I wanted to make sure whether I need to wait for these changes to be merged.

diosmosis commented 1 year ago

@snake14 these changes don't have to be merged right now. We can make this PR a draft if you want.

snake14 commented 1 year ago

Thank you @diosmosis . I'll mark this PR as needing to be migrated to 5.x