Closed diosmosis closed 1 year ago
@diosmosis Why is this change necessary? The builds are currently passing on 4.x-dev.
@snake14 its to fix the build if/when matomo-org/matomo#20592 is merged. It's a preemptive build fix. (which is therea no needs review label)
@diosmosis It looks like the core PR didn't get merged. Should this PR be closed? We're trying to create beta releases for the plugins and I wanted to make sure whether I need to wait for these changes to be merged.
@snake14 these changes don't have to be merged right now. We can make this PR a draft if you want.
Thank you @diosmosis . I'll mark this PR as needing to be migrated to 5.x
Description:
Depends on https://github.com/matomo-org/matomo/pull/20592
As title.
Review