search

matomo-org / plugin-EnvironmentVariables

Allows you to specify Matomo config in environment variables instead of the config file.
12 stars 14 forks source link

Unable to set email addresses via environment variables #7

Open sean-mcgimpsey opened 5 years ago

sean-mcgimpsey commented 5 years ago

Trying to automate the deployment of matomo, noticing that the following variables do not work.

MATOMO_GENERAL_LOGIN_PASSWORD_RECOVERY_EMAIL_ADDRESS MATOMO_GENERAL_LOGIN_PASSWORD_RECOVERY_EMAIL_NAME MATOMO_GENERAL_NOREPLY_EMAIL_ADDRESS

as well as all Mail settings, which has already been raised.

tsteur commented 5 years ago

I don't have a setup right now to test this. But do you know what is exactly not working or why? Is it not reading any values from it at all or is it not correctly encoded?

sean-mcgimpsey commented 5 years ago

Even though the environment variables are correctly set, the config.ini.php is not being updated with the values, they are completely ignored.

tsteur commented 5 years ago

The config.ini.php shouldn't necessarily be updated with these values when you set these environment variables. They would currently only be updated if you make some other changes that trigger a "config save" such as changing the list of trusted hosts in General Settings.

These settings are applied on demand so it doesn't mean it's not working when you don't see the changes there.

sean-mcgimpsey commented 5 years ago

Ok, but even though the environment variables are set (have confirmed that they are set by echoing), they are not respected by the application. The from addresses are not updated to the value of the env var. I've tested this on a fresh install.

tsteur commented 5 years ago

I've looked through the code and this should work. Not sure where you echoed when testing. Can you do this here https://github.com/matomo-org/plugin-EnvironmentVariables/blob/3.0.0/config/config.php#L23 and also check if it goes into that if?