Added code to remember GA Import baner dismiss action, #PG-2925

AltamashShaikh commented 1 year ago

Description:

Added code to remember GA Import baner dismiss action Fixes: #PG-2925

Review

[ ] Functional review done
[ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
[ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
[ ] Security review done
[ ] Wording review done
[ ] Code review done
[ ] Tests were added if useful/possible
[ ] Reviewed for breaking changes
[ ] Developer changelog updated if needed
[ ] Documentation added if needed
[ ] Existing documentation updated if needed

AltamashShaikh commented 1 year ago

@snake14 to test this add this below code here

return json_encode(['showNotification' => true, 'configureURL' => SettingsPiwik::getPiwikUrl() . 'index.php?' . Url::getQueryStringFromParameters([
                'idSite' => $currentIdSite,
                'module' => 'GoogleAnalyticsImporter',
                'action' => 'index',
            ])]);

snake14 commented 1 year ago

@snake14 to test this add this below code here

return json_encode(['showNotification' => true, 'configureURL' => SettingsPiwik::getPiwikUrl() . 'index.php?' . Url::getQueryStringFromParameters([
                'idSite' => $currentIdSite,
                'module' => 'GoogleAnalyticsImporter',
                'action' => 'index',
            ])]);

Thank you for providing the easy reproduction steps @AltamashShaikh :+1:

matomo-org / plugin-GoogleAnalyticsImporter

Added code to remember GA Import baner dismiss action, #PG-2925 #470

Description:

Review