matomo-org / plugin-GoogleAnalyticsImporter

Google Analytics to Matomo importer
24 stars 14 forks source link

Disable re-import date range feature for GA3, #L3-761 #534

Closed AltamashShaikh closed 3 months ago

AltamashShaikh commented 3 months ago

Description:

Disable re-import date range feature for GA3 Fixes: #L3-761

Review

AltamashShaikh commented 3 months ago

@adammaddox @patrickli We should include this too in tomorrow's release.

AltamashShaikh commented 3 months ago

The frontend code change is a bit too much for me to see any changes. Shall we disable the GA3 checkbox in the UI and add a message next to it to explain why? Throwing an exception on submit is not very user friendly. Or is this just effecting re-import not a fresh new one?

@patrickli We have that task to deprecate the GA3 Import, currently we are just hiding the re-import ranges option to ensure we don't face more similar issues.

patrickli commented 3 months ago

Make sure this is merged before tomorrow morning NZ time so I can update matomo-cloud.

AltamashShaikh commented 3 months ago

@patrickli A new version of the plugin is released, we can update the same :+1: