[Vue] migrate log viewer directive to vue

diosmosis commented 2 years ago

Description:

Changes:

Migrate log viewer directive to vue.

Review

[ ] Functional review done
[ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
[ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
[ ] Security review done
[ ] Wording review done
[ ] Code review done
[ ] Tests were added if useful/possible
[ ] Reviewed for breaking changes
[ ] Developer changelog updated if needed
[ ] Documentation added if needed
[ ] Existing documentation updated if needed

diosmosis commented 2 years ago

@AltamashShaikh applied the fixes

diosmosis commented 2 years ago

@AltamashShaikh fixed the issues. The error notification fix requires https://github.com/matomo-org/matomo/pull/19071 to merged in core.

diosmosis commented 2 years ago

@AltamashShaikh can you check you are using https://github.com/matomo-org/matomo/pull/19071 locally? And if its still there after pulling/clearing cache, tell me how you triggered the error?

AltamashShaikh commented 2 years ago

@diosmosis All looks good with https://github.com/matomo-org/matomo/pull/19071 :+1:

matomo-org / plugin-LogViewer

[Vue] migrate log viewer directive to vue #52

Description:

Review