matomo-org / plugin-MarketingCampaignsReporting

GNU General Public License v3.0
25 stars 19 forks source link

Correcting plural of "Mediums" to "Media" #154

Open terpfear opened 5 months ago

terpfear commented 5 months ago

Description:

This change comes at the request of our marketing team, who are in charge of all the language and grammar on our website. They have pointed out that the correct plural of "Mediums" is "Media" in this context.

Review

AltamashShaikh commented 5 months ago

@terpfear Thankyou for your PR, but Campaign Medium is the most widely used and generic term, I am not sure if we will be able to merge this PR.

sgiehl commented 5 months ago

@AltamashShaikh The plural can indeed be mediums or media depending on the context. Might be good to maybe ask Gillian for advice.

AltamashShaikh commented 4 months ago

@AltamashShaikh The plural can indeed be mediums or media depending on the context. Might be good to maybe ask Gillian for advice.

@sgiehl After checking with Gillian, she is also of opinion of not changing it to Media.

"I understand that media can be plural for medium based on context, but changing to Campaign Media here does not fit and could mean something else entirely - if there was going to be a change, I would rather just change Mediums to Medium. or keep all of these labels singular"