Make vendor proxy changes work

matomo-org / plugin-Migration

Migrate a Matomo Measurable (website, app, roll-up, ...) from one Matomo instance to another Matomo

5 stars 11 forks source link

Make vendor proxy changes work #51

Closed snake14 closed 1 year ago

snake14 commented 1 year ago

Description:

This is fixing the console command to meet the Matomo 5 vendor proxy requirements.

Review

[ ] Functional review done
[ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
[ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
[ ] Security review done
[ ] Wording review done
[ ] Code review done
[ ] Tests were added if useful/possible
[ ] Reviewed for breaking changes
[ ] Developer changelog updated if needed
[ ] Documentation added if needed
[ ] Existing documentation updated if needed

snake14 commented 1 year ago

@sgiehl @bx80 @michalkleiner I found that this plugin didn't have a PR for vendor proxies, so I went ahead and created one. Can one of you please look over my changes and make sure that I got everything?

I tested the command locally and it worked. That's how I caught the switch from Symfony dialog to question. Should that be mentioned in the migration docs somewhere?

sgiehl commented 1 year ago

@snake14 I had only created PRs for those plugins that I had installed locally. There might actually more be missing...

Regarding the migration guide... Isn't this part enough:

* Directly using any console helpers is now prohibited
  * To ask for user input use the new methods askForConfirmation, askAndValidate or ask
  * For a progress bar use the methods initProgressBar, startProgressBar, advanceProgressBar and finishProgressBar
  * To render tables use the new method renderTable

snake14 commented 1 year ago

Thank you @sgiehl. Sounds good. I'll keep working my way through the list of all of the plugins our team maintains and create any missing PRs.

I guess I just wasn't familiar with the Symfony helper classes, like dialog, so I didn't know what I was looking for. It probably would have helped if that was actually formatted as a bulleted list in the documentation; It would have been easier to spot and pick out that way. I'll see if I can fix that in my open documentation PR.

Edit: Looks like you already fixed the lists since the last time I refreshed the page. Thank you.