search

matomo-org / plugin-Provider

Reports the Internet Service Provider of your visitors as part of your Matomo Analytics
4 stars 6 forks source link

Use geo ip detection even if dp=1 param is given #13

Closed sgiehl closed 3 years ago

sgiehl commented 3 years ago

The GeoIP lookup should already have been done for the location nevertheless, so it would be useless to throw the result away without using it. And the dp param was only to speed up the tracking and avoid the reverse dns lookups, which would still remain the same.

diosmosis commented 3 years ago

Is this a widely used tracking parameter? I guess there might be some questions from users that suddenly see provider data available. Perhaps very few actually use it though.

sgiehl commented 3 years ago

It's actually set by default when importing logs. But the parameter there actually is called reverse_dns, so it might be unexpected actually that also geoip lookups wouldn't happen. And those that don't want to use it can simply disable the plugin....