search

matomo-org / plugin-TrackingSpamPrevention

GNU General Public License v3.0
12 stars 7 forks source link

Digitial ocean IP list is no longer syncing #78

Closed tsteur closed 1 year ago

tsteur commented 1 year ago

Getting this error daily since Saturday

Scheduler: Error Failed to retrieve digital ocean IP ranges for task 'Piwik\Plugins\TrackingSpamPrevention\Tasks.updateBlockedIpRanges'

The URL https://www.digitalocean.com/geo/google.csv returns a not found page.

Because of this error the task no longer finishes (which is kind of on purpose so we notice such errors).

snake14 commented 1 year ago

@tsteur How long ago did this error start? If it's recent, it could be related to some DNS issues that DigitalOcean had over the weekend. The page is still linked to on their page. It also appears that this page has had issues before. Should we wait for a bit and see what happens or use an alternative?

tsteur commented 1 year ago

It started last Friday or Saturday. Sure we can wait for a few days we should just not forget. We'll likely receive daily emails about this so can also keep commenting from time to time about it

AltamashShaikh commented 1 year ago

Refer - https://github.com/matomo-org/plugin-TrackingSpamPrevention/pull/67 for previous fix

AltamashShaikh commented 1 year ago

FYI: I added a comment here to notify digitalocean

tsteur commented 1 year ago

FYI it's still not working.

AltamashShaikh commented 1 year ago

Yes, and no reply on the forum too, the documentation still mentions this URL to download the required data though

AltamashShaikh commented 1 year ago

Just FYI, created a ticket on DigitalOcean as there was no reply on the blog comment

sgiehl commented 1 year ago

Just a general thought on that one. Should we maybe change the tests, so they work with dummy response data, and don't really send requests to the cloud providers? That would avoid failing tests. To ensure that the URLs are still available we could also have a simply github action, that queries that urls and checks if the data still has the same format. Such an action could e.g. run daily or weekly.

AltamashShaikh commented 1 year ago

FYI, Just received a message from DigitalOcean that they have reported to the team internally and they are looking for a fix

AltamashShaikh commented 1 year ago

@tsteur Its up now and seems to download the CSV. Can you check if the error is gone ?

tsteur commented 1 year ago

Awesome, thanks @AltamashShaikh . I suggest you close the issue and I can always comment again should I keep receiving errors about it.