Removed PHP 7.4 from builds in favor of PHP 8.1

snake14 commented 1 year ago

Description:

To try and reduce the number of Travis builds, we are removing PHP 7.4 from the builds so that we're only using PHP 7.2 and 8.1 for builds.

Review

[ ] Functional review done
[ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
[ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
[ ] Security review done
[ ] Wording review done
[ ] Code review done
[ ] Tests were added if useful/possible
[ ] Reviewed for breaking changes
[ ] Developer changelog updated if needed
[ ] Documentation added if needed
[ ] Existing documentation updated if needed

snake14 commented 1 year ago

@sgiehl Any recommendations for dealing with the errored 8.1 build? It appears to be an issue with the core 4.0.5 not being PHP 8.1 friendly. Is there something that I can change in the plugin to make the build not throw all those deprecation errors?

sgiehl commented 1 year ago

@snake14 It might not make much sense to run tests on PHP 8.1 for a Matomo version that is not fully compatible with that PHP version. Maybe it might be enough to run the minimum required version tests on for PHP 7.2 and let PHP 8.1 only test against 4.x-dev

snake14 commented 1 year ago

@snake14 It might not make much sense to run tests on PHP 8.1 for a Matomo version that is not fully compatible with that PHP version. Maybe it might be enough to run the minimum required version tests on for PHP 7.2 and let PHP 8.1 only test against 4.x-dev

Thank you @sgiehl . Sounds good. I'll remove the minimum Matomo version test from PHP 8.1 for now. We can always add it back in for version 5.0.0.

matomo-org / plugin-TrackingSpamPrevention

Removed PHP 7.4 from builds in favor of PHP 8.1 #80

Description:

Review