matoom / frostbite

MUD client for dragonrealms.
29 stars 17 forks source link

Segmentation fault (core dumped) #18

Closed Dartellum closed 7 years ago

Dartellum commented 7 years ago

Cleint crashed with Segmentation fault (core dumped) in terminal.

matoom commented 7 years ago

Ok, i think i now have a fix in place for lich stream message issues and based on your report from the last round of testing, i'm again quite hopeful.

Got another test release ready at: https://github.com/matoom/frostbite/releases/download/v1.4.1-beta/frostbite-debian64-streamfix.tar.gz

Dartellum commented 7 years ago

Okay. I will try it out in a bit. :)

Dartellum commented 7 years ago

The spell list is still compressed in the Active Window with no times associated. image

Dartellum commented 7 years ago

Okay, thoughts are going to the Thoughts window (yay!) but no lnnet (Lich) chat is. image

Example from the nospells version (with same Trade chat time to show no DR-Prime chat is showing): image

matoom commented 7 years ago

Oh, well, i essentially went back to the similar system that nospells was using but there's still one distinctive difference that is the current version still cares about correctness.

It probably didnt show up when i was testing because khri is different from spells and my mage only has one spell but lich likes to cut things in half. Can't cut 1 in half.

I'm actually eligible for one more spell so i can probably reproduce this and then either compensate for broken data or do something i didn't want to do -- keep track of tags and always make sure everything is there. Only problem is the latter runs a risk of complete failure in case there actually is issues in data.

Either way, i'll probably come up with something again, soon.

Dartellum commented 7 years ago

I have numbers for a brief moment then they go away. Thanks!

Dartellum commented 7 years ago

image

then they go away.

matoom commented 7 years ago

Yea, lich is pretty much spamming at random i'm afraid. :)

Meanwhile i went to get a new spell for myself and ran into more trouble. It seems like the previous "nospells" version was cutting everything it didn't like so i missed a whole lot of messages going through the spell choosing process. It seems there's an entirely new window opening up in stormfront (there's nothing like that for thieves).

I'll probably leave this one for later though.

matoom commented 7 years ago

Ok, i don't know, i made more changes and was able to last 30 minutes with 2 spells active and no garbled text.

I have another build ready for testing if you have the time: https://github.com/matoom/frostbite/releases/download/v1.4.1-beta/frostbite-debian64-streamfix2.tar.gz

Also if you see an error with "Stream limit exceeded!" let me know, i'll increase the limit. It's a fail safe mechanic in case client waits for a "popStream" that never comes.

Dartellum commented 7 years ago

Okay, pulled the latest down.

Edit - looking good so far. :)

Dartellum commented 7 years ago

Hunted and works well. The only thing I have seen is a main window item in Thoughts - once (the go2). image

matoom commented 7 years ago

Any chance you have a debug log of that go in the thoughts? I have no idea how that could have got there.

Dartellum commented 7 years ago

I failed to turn it on. I will turn on for my next run. I went a few hours of hunting with no crashes before I disconnect to go to class.

-- Regards, Dr. Walter Wesley "Wes" Snyder V 484-300-4833 (h) 484-431-3355 (m) 484-302-7006 (f)

On 11/30/2016 04:39 PM, matoom wrote:

Any chance you have a debug log of that go in the thoughts? I have no idea how that could have got there.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/matoom/frostbite/issues/18#issuecomment-264003867, or mute the thread https://github.com/notifications/unsubscribe-auth/AU8XXMwZ2dCCw-7VXmom5hb_0i34fH96ks5rDe0KgaJpZM4K4kI8.

matoom commented 7 years ago

Ok, finally some good news at least. The thoughts thing doesn't seem too serious if it doesn't happen too often but if possible would still like to fix that too.

Dartellum commented 7 years ago

I had a crash when adding highlights:

wes@dragon:~$ '/home/wes/frostbite-1.4.1b-streamfix2-2/frostbite' libpng warning: iCCP: known incorrect sRGB profile libpng warning: iCCP: known incorrect sRGB profile libpng warning: iCCP: known incorrect sRGB profile libpng warning: iCCP: known incorrect sRGB profile libpng warning: iCCP: known incorrect sRGB profile libpng warning: iCCP: known incorrect sRGB profile libpng warning: iCCP: known incorrect sRGB profile libpng warning: iCCP: known incorrect sRGB profile libpng warning: iCCP: known incorrect sRGB profile libpng warning: iCCP: known incorrect sRGB profile libpng warning: iCCP: known incorrect sRGB profile libpng warning: iCCP: known incorrect sRGB profile Error: signal 11: /home/wes/frostbite-1.4.1b-streamfix2-2/frostbite(_Z7handleri+0x2e)[0x50ba9e] /lib/x86_64-linux-gnu/libc.so.6(+0x354b0)[0x7f07703f74b0] /home/wes/frostbite-1.4.1b-streamfix2-2/frostbite(ZN5QListI22HighlightSettingsEntryE6appendERKS0+0x7)[0x4f92e7] /home/wes/frostbite-1.4.1b-streamfix2-2/frostbite(_ZN17HighlightSettings12loadSettingsE7QString+0x5ed)[0x4f838d] /home/wes/frostbite-1.4.1b-streamfix2-2/frostbite(_ZN17HighlightSettings11getSettingsE7QString+0x5e)[0x4f8e0e] /home/wes/frostbite-1.4.1b-streamfix2-2/frostbite(_ZN11Highlighter9highlightE7QString+0xb2)[0x4ec2e2] /home/wes/frostbite-1.4.1b-streamfix2-2/frostbite(_ZN16GridWriterThread7processE9GridEntry+0xdf)[0x56c90f] /home/wes/frostbite-1.4.1b-streamfix2-2/frostbite(_ZN16GridWriterThread3runEv+0x1dd)[0x56d1cd] /home/wes/frostbite-1.4.1b-streamfix2-2/lib/libQt5Core.so.5(+0xaa729)[0x7f07712f3729] /lib/x86_64-linux-gnu/libpthread.so.0(+0x770a)[0x7f077103370a] /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x7f07704c882d] Error: signal 11: /home/wes/frostbite-1.4.1b-streamfix2-2/frostbite(_Z7handleri+0x2e)[0x50ba9e] /lib/x86_64-linux-gnu/libc.so.6(+0x354b0)[0x7f07703f74b0] /home/wes/frostbite-1.4.1b-streamfix2-2/lib/libQt5Gui.so.5(_ZN11QAccessible24queryAccessibleInterfaceEP7QObject+0x484)[0x7f0771fc64e4] /home/wes/frostbite-1.4.1b-streamfix2-2/lib/libQt5Gui.so.5(_ZNK16QAccessibleEvent19accessibleInterfaceEv+0x23)[0x7f0771fc6b33] /home/wes/frostbite-1.4.1b-streamfix2-2/lib/libQt5Gui.so.5(_ZN11QAccessible19updateAccessibilityEP16QAccessibleEvent+0xd)[0x7f0771fc6f3d] /home/wes/frostbite-1.4.1b-streamfix2-2/lib/libQt5Widgets.so.5(ZN9QListView16selectionChangedERK14QItemSelectionS2+0xb0)[0x7f0772dce0d0] QObject::~QObject: Timers cannot be stopped from another thread Segmentation fault (core dumped) wes@dragon:~$

matoom commented 7 years ago

I've had it crash before but i haven't been able to capture it since it has always happened on windows with no debugging data enabled.

Now that i'm looking at it, i still don't know what's exactly causing this issue but i will probably try something either way. Thanks for letting me know. Getting some good bug fixes done lately. :)

matoom commented 7 years ago

Actually i have one question, did you do anything with profiles before starting to add highlights? I'm trying to figure out how "loadSettings" was called and as far as i can tell that can only happen one of two ways.

Dartellum commented 7 years ago

Yes, I created and loaded a profile.

-- Regards, Dr. Walter Wesley "Wes" Snyder V 484-300-4833 (h) 484-431-3355 (m) 484-302-7006 (f)

On 12/01/2016 01:30 PM, matoom wrote:

Actually i have one question, did you do anything with profiles before starting to add highlights? I'm trying to figure out how "loadSettings" was called and as far as i can tell that can only happen one of two ways.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/matoom/frostbite/issues/18#issuecomment-264253580, or mute the thread https://github.com/notifications/unsubscribe-auth/AU8XXHrtlKtGsihCgtzmnXLRLgPBqVvfks5rDxJfgaJpZM4K4kI8.

matoom commented 7 years ago

I fixed a possible memory leak in highlights and tested by inserting the entire alphabet multiple times, i did not experience any crashes but i could never really consistently reproduce this.

There were some other issues. It seems that the linux qt5 isn't really up to date as much as the other two (which was already evident by the size of the binaries, a lot of dead weight in linux release) and there were some problems showing an arrow in highlights. I fixed those as well and did some style synchronization between linux and windows visuals.

If you still have any highlights to add or are able to test it, have the new experimental release up again: https://github.com/matoom/frostbite/releases/download/v1.4.1-beta/frostbite-debian64-hl.tar.gz

Dartellum commented 7 years ago

Will test! Can I just drop the frostbite program over the old one in my existing folder?

matoom commented 7 years ago

Yea, that's what i've been doing for the past 10 releases :) As long as it's qt5.6, shouldn't be a problem.

Dartellum commented 7 years ago

Good stuff!

This error occurred, maybe permissions(?): 59969961 [] ERROR Log4Qt::DailyRollingFileAppender - Unable to rename file 'logs/debug/debug.log' to 'logs/debug/debug.log.2016-12-02' for appender 'A6' (Log4Qt::DailyRollingFileAppender::APPENDER_RENAMING_FILE_ERROR, 9): Source file does not exist (10) 59970011 [] ERROR Log4Qt::DailyRollingFileAppender - Unable to rename file 'logs/main/main.log' to 'logs/main/main.log.2016-12-02' for appender 'A1' (Log4Qt::DailyRollingFileAppender::APPENDER_RENAMING_FILE_ERROR, 9): Source file does not exist (10) Error: signal 11: Error: signal 11: /home/wes/frostbite-1.4.1b-streamfix2-1/frostbite/home/wes/frostbite-1.4.1b-streamfix2-1/frostbite((_Z7handleri_Z7handleri+0x+0x2e2e))[0x[0x50ba9e50ba9e]

Dartellum commented 7 years ago

I figured out the name change of the logs. I needed to launch from the directory for it to work. What I mean, I need to cd to /home/wes/frostbite-1.4.1b-streamfix2-1 and launch Frostbite from there for the log renaming to work.

matoom commented 7 years ago

Oh, ok, i was already fixing an issue i found with the log file rollover causing a crash when the log file was missing. Possibly deleted during run time on Linux since the file is not locked.

This changes things a little bit.

The problem is that the log implementation is not something i created myself. I'm using the log4qt framework and judging by the fact that last commits are 3-4 years ago the original author isn't actively working on it. I'll have to see if there is something i can do about that.

Not sure if any of it works if the "working directory" is not relative to the file paths. It could have just been running on default config for everything.