search

matoom / frostbite

MUD client for dragonrealms.
29 stars 17 forks source link

Monster bold/highlighting in Room window #35

Closed Dartellum closed 7 years ago

Dartellum commented 7 years ago

I figured I would open an issue so it is not lost. Monster bold/highlighting works in the Main window but not in the Room window. I believe you said it has something to do with how the game sends the data.

matoom commented 7 years ago

I'll have to look into this one again, i don't recall exactly what the problem was but i think something related to the way i parse the protocol, so some changes are probably needed.

Just that i don't i forget, familiar window likely needs the same changes and some other issues related to "style" parsing.

The last release introduced some new memory issues i need to look into first though. I don't have any evidence of a memory leak but there's definitely a memory surplus.

Dartellum commented 7 years ago

I run three on my computer: [image: Inline image 2]

Regards, Dr. Walter Wesley "Wes" Snyder V 484-300-4833 (h) 484-431-3355 (m)

On Wed, Sep 6, 2017 at 12:28 PM, matoom notifications@github.com wrote:

I'll have to look into this one again, i don't recall exactly what the problem was but i think something related to the way i parse the protocol, so some changes are probably needed.

Just that i don't i forget, familiar window likely needs the same changes and some other issues related to "style" parsing.

The last release introduced some new memory issues i need to look into first though. I don't have any evidence of a memory leak but there's definitely a memory surplus.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/matoom/frostbite/issues/35#issuecomment-327539323, or mute the thread https://github.com/notifications/unsubscribe-auth/AU8XXB_w7GfwtZvpYevRZG0hEr8w2tUfks5sfsgrgaJpZM4POUOR .

matoom commented 7 years ago

I think something happened to the image you uploaded (doesn't show). I was doing some testing and memory usage climbed up to 350mb and then dropped again down to 50 when i stopped for a little while. It's good that the memory got released after a while but i don't think it should go that high in the first place.

matoom commented 7 years ago

I have a fix ready for both issues in v1.7.1.

https://github.com/matoom/frostbite/releases/tag/v1.7.1-beta

Dartellum commented 7 years ago

I started testing 1.7.1b about 2 hours ago :) Looking good!

Regards, Dr. Walter Wesley "Wes" Snyder V 484-300-4833 (h) 484-431-3355 (m)

On Sun, Sep 10, 2017 at 2:33 PM, matoom notifications@github.com wrote:

I have a fix ready for both issues in v1.7.1.

https://github.com/matoom/frostbite/releases/tag/v1.7.1-beta

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/matoom/frostbite/issues/35#issuecomment-328362331, or mute the thread https://github.com/notifications/unsubscribe-auth/AU8XXGX84IfGDhmJ5OUjIvMt66Lp9_Vnks5shCuNgaJpZM4POUOR .

Dartellum commented 7 years ago

Looks good still. Closing.