search

matortheeternal / smash

An application that provides a means of performing automatic conflict resolution between multiple Bethesda Plugin Files for TES and Fallout games.
Other
129 stars 20 forks source link

UTF8 Support #169

Open matortheeternal opened 6 years ago

millmill12345 commented 6 years ago

Where is the character-code defined?

matortheeternal commented 6 years ago

It looks like all we have to do is set wbStringEncoding := seUTF8;

https://github.com/TES5Edit/TES5Edit/blob/dev/wbInit.pas#L768-L771

millmill12345 commented 6 years ago

I see, it seems to only set command-line argument to "-cp:utf-8" to set UTF8. Text garbled, it needs something else.

matortheeternal commented 6 years ago

xEdit executes wbStringEncoding := seUTF8; when the command line argument is provided. Smash does not support the same command line arguments as xEdit, but it uses the xEdit framework, so setting wbStringEncoding to UTF8 in Smash, per e00ae70, should get the job done.

millmill12345 commented 6 years ago

Great work, I think this method will also deliver same good result on your "Merge Plugins".

matortheeternal commented 6 years ago

Using UTF8 encoding appears to cause problems for users of Russian game installations. Using a command line parameter for Smash should fix this problem.