search

matortheeternal / smash

An application that provides a means of performing automatic conflict resolution between multiple Bethesda Plugin Files for TES and Fallout games.
Other
128 stars 20 forks source link

CELL/FULL not always forwarded #204

Open cmeeren opened 6 years ago

cmeeren commented 6 years ago

I'm new to Mator Smash and Skyrim modding in general, so I'm sorry if I'm using the wrong terms.

I'm trying to create a Smashed patch for my load order. I'm using MLU.esp from OMEGA, as well as ELE_SSE.esp (Enhanced Lightning for ENB). The former edits the name of a lot of interior cells (CELL/FULL), whereas the latter edits the lightning in most interior cells. I want Mator Smash to forward(?) the name changes from the OMEGA MLU.esp and the lighting changes from ELE.

I have MLU.esp set to Smash.ForceAll as per the recommendations on Mator Smash's Nexus page. In order to make Mator.Smash use the name changes in MLU.esp, I have created a new Smash setting for all mods that load below MLU.esp. This setting is a copy of Smash.All, just with CELL/FULL unchecked.

This works for most cell records, but there is a handful that do not seem to be picked up and included in the Smashed patch.

Do you have any idea what (if anything) could be wrong, or how I can ensure that the CELL/FULL changes from MLU.esp are always included (without creating a manual patch, which is my plan B)?

Below are screenshots of 1) a record where CELL/FULL was included in the Smashed patch, and 2) a record where it was not.

included

not included

Mincol commented 6 years ago

This might be related to https://github.com/matortheeternal/smash/issues/203.

For ELE changes to be propagated, you can use my settings called BashC.Light-My and can be downloaded https://github.com/matortheeternal/smash/files/2146516/Skyrim.zip Extract file called BashC.Light-My, store it in Mator.Smash\settings\Skyrim and mark ELE to use BashC.Light-My instead of BashC.Light

Mincol commented 6 years ago

I believe that force is not needed as you do not have conflicts.

Smash.ForceAll is a special smash setting which forces smash to use records from the plugin it is applied to, and ignore conflicts with these records unless they belong to a plugin which requires the plugin as a master. This should be useful to users running Requiem.

cmeeren commented 6 years ago

Thanks for the Bash settings. But why isn't the lighting carried over? I even tried a custom setting where I forced the relevant CELL sub-records from ELE, but Smash still didn't use the lighting changes.

Regarding Force, I use it for MLU since it's officially recommended. I think it's related to leveled lists (not relevant for this issue).

Also, yes, it might be related to #203.

cmeeren commented 6 years ago

@Mincol no matter what I do and which settings I use, I can't get the ELE changes propagated.

Mincol commented 6 years ago

@cmeeren make sure you do not use Smash.ForcaAll, but Smash.All. I will try it tonight.

Mincol commented 6 years ago

I can reproduce it: image Cell \ Block 0 \ Sub-Block 0 is missing from smashed patch.

cmeeren commented 6 years ago

Note that most of the missing records are included when the "Preserve ITPO" setting in Mator Smash is checked. However, the ELE lighting changes are still not propagated.

matortheeternal commented 6 years ago

Question: If you enable "Preserve ITPOs", is the record in the smashed patch with a FULL name identical to what is in ELE_SSE.esp?

Mincol commented 6 years ago

With "Preserve ITPOs" image What language is used to write Smash? Is it Pascal? Is tooling free? I did Pascal at school more than 15 years ago and do java for money now...

cmeeren commented 6 years ago

@matortheeternal I'm on holiday and can't test at the moment, but IIRC:

matortheeternal commented 6 years ago

@Mincol looks like the issue is detecting ITPO status then. The problem isn't that the FULL isn't getting forwarded, it's that Smash removes the record as an ITPO when it isn't.

Smash is Delphi (object oriented pascal) because the xEdit framework (which is what it's built on) is Delphi. You can download Delphi Start Edition from embarcadero for free.

@cmeeren The lighting not being included is a separate issue if that's happening.

cmeeren commented 6 years ago

Yes, I'm 98% sure the lighting was not included, at least for a large number of records (I only looked at the conflicts, so there might have been records where things worked, but there sure was a lot of faulty ones). A temporary workaround I did was to create a custom CR patch where I copied the ELE cell records and forward the FULL change from the OMEGA MLU.esp.

matortheeternal commented 6 years ago

If you could make a separate github issue about lighting not forwarding with screenshots I'll look into fixing it for the next release.

jgoulet commented 5 years ago

Posted something on Nexus but just came across this thread. I'm having a similar issue with some textures:

After smashing my plugins, some of the NPCs didn't have any hand textures. Turns out, they all used FarmerGloves03AA, which was modified in my patch (between Remodeled Armor for CBBE, USSEP, and Skyrim.esm). When I pulled up the comparison pane, for some reason the First Person Flags for the Smashed Patch were blank, even though each of the other files had them as 33 - Hands. USSEP had 36 - Ring additionally, but I'm not sure that would cause this behavior because I assumed the Remodeled Armor mod would just take precedence. Once I added the 33 - Hands flag to the patch, voila, the hands appear in game! Additionally, for some reason they were flagged as Light Armor in the patch even though they are flagged as Clothing in all the others (I'm thinking that may be the default if you add a new flag though).

For good measure, I went down the list and found FineBoots02AA in the same state. All the flags were identical for the 3 files, but somehow didn't make it to the patch.

Does this sound related to the Preserve ITPO setting?

Edit: that setting wasn't enabled. So it sounds like I have the same issue as OP's lighting from ELE not propagating. Was a fix ever determined for this?