search

matplotlib / CZI_2019-07_mpl

4 stars 4 forks source link

Suggested edits, comments, and re-arrangements #3

Closed jklymak closed 5 years ago

jklymak commented 5 years ago

@tacaswell This is looking quite nice. I like the technical write-ups and think they are at the right level and make a good case for the support. A couple of high-level suggestions:

You never define what matplotlib is! Suggested re-arrangement in my changes, but you probably don't want to accept as-is.

Just saying we want to close Issues/PRs doesn't seem to me to be a winner. I can't imagine CZI actually cares about our closure rate. Its just a number. We care, but I still think the better sell is pitching this as community building. We are losing potential developers because we dont' have time to properly help them, and/or their PRs take forever to be merged or closed. the closures are particularly bad, because sometimes very well meaning people spend a long time on a change, but no one has taken the time to tell them that it won't likely be accepted. Having you, or someone like you, paying attention to PRs and arbitrating what should go forward and what should be cutoff early is super valuable, but not because of some number, but because it makes the most efficient use of community resources.

tacaswell commented 5 years ago

Thanks @jklymak ! I took it whole and then did another editing pass on top.

The nice thing about the number is it is easy to quantify if we have hit it or not.

jklymak commented 5 years ago

I think a number is fine for a milestone, and I think its an important number, just suggesting that we want to emphasize that the number is a sign of community health.

tacaswell commented 5 years ago

If you still have, cycles can you look at what I just pushed? I'm :zzz: for the night....