search

matplotlib / basemap

Plot on map projections (with coastlines and political boundaries) using matplotlib
MIT License
775 stars 392 forks source link

Deprecation warning for np.readfromstring #385

Closed scollis closed 6 years ago

scollis commented 6 years ago

Seems to both be in init b = np.array(np.fromstring(polystring,dtype='<f4'),'f8') /home/travis/miniconda3/envs/testenv/lib/python2.7/site-packages/mpl_toolkits/basemap/init.py:1303: DeprecationWarning: The binary mode of fromstring is deprecated, as it behaves surprisingly on unicode inputs. Use frombuffer instead

WeatherGod commented 6 years ago

so, is it just a straight-out replacement of fromstring to frombuffer? Any py3k stuff I have to worry about?

scollis commented 6 years ago

Not that I have seen from Py-ART. I am a bit nervous but I tested all our reads and they worked.. All care no responsibility.

How often do you cut a new conda package? This creates some long travis logs :)

WeatherGod commented 6 years ago

I just let conda-forge automatically(?) do it. Remember, people are supposed to be getting off of basemap and using cartopy!

scollis commented 6 years ago

Oh! I know @WeatherGod The only reason I did not catch this before CI did on Py-ART is I do not use any of the basemap hooks we have.. Completely Cartopy for me! This will serve as a nice lesson to our users though, I will be sure to send the word

scollis commented 6 years ago

Let me know if you want @zssherman or I to submit the PR

WeatherGod commented 6 years ago

Just about done with it (I know... shocking!)