matplotlib / cmocean

Colormap setup for standardizing commonly-plotting oceanographic variables.
MIT License
230 stars 52 forks source link

Added MANIFEST.in #43

Closed ocefpaf closed 8 years ago

ocefpaf commented 8 years ago

In this PR:

Note that the test is a simple: 'does this work' rather than a figure comparison test. I am not sure if figure comparison is necessary here though. But we can improve this a little bit. They can fail silently. We can add things like a list of the expected colormaps.

Also, the colormaps are no longer in the main namespace as the previous test expected . (They where failing silently.) Do you want them there? Or the API cmocean.cm.<cmap> is OK?

kthyng commented 8 years ago

Ok great. Which way do you think would be best for where the colormaps are located?

ocefpaf commented 8 years ago

I like cmocean.cm.<cmap>, but I don't have any strong options about it.

kthyng commented 8 years ago

Ok so it is good as is then, I think.