Remove centering of plot on firefox

matplotlib / ipympl

Matplotlib Jupyter Integration

https://matplotlib.org/ipympl/

BSD 3-Clause "New" or "Revised" License

1.57k stars 227 forks source link

Remove centering of plot on firefox #421

Closed ianhi closed 2 years ago

ianhi commented 2 years ago

Followup to: afdebbfade53785434b7ac7fe3965480895b6ccd

which didn't have centering for chrome, but did for firefox

cc @martinRenou this shouldn't do anything bad (I think?) and fixes the centering for me on firefox

github-actions[bot] commented 2 years ago

:point_left: Launch a binder notebook on branch ianhi/ipympl/centering

martinRenou commented 2 years ago

Thanks a lot! I'll do a release right away

martinRenou commented 2 years ago

The visual regression tests were not passing I had to update the references. It looks like this was having an impact on the header position on Chrome? It is unclear to me why it was behaving differently on Firefox vs Chrome.

martinRenou commented 2 years ago

The remaining failures are unrelated to this PR. I believe we need to do something similar as in bqplot https://github.com/bqplot/bqplot/pull/1440. I'll push another PR for that.