matplotlib / ipympl

Matplotlib Jupyter Integration
https://matplotlib.org/ipympl/
BSD 3-Clause "New" or "Revised" License
1.59k stars 225 forks source link

support double click events #446

Closed ianhi closed 2 years ago

ianhi commented 2 years ago

closes: #261 attn @nvaytet

@martinRenou for version numbers what do we do here? I think we need to bump package.json https://github.com/matplotlib/ipympl/blob/21a1c8dde81e5732606c41054285ab2def9dba9f/package.json#L3

to either 0.11.0 or 0.10.6 and also bump the python version. Is there anything we can do here to ameliorate the patch version incompatibility (#416)?

github-actions[bot] commented 2 years ago

Binder :point_left: Launch a binder notebook on branch ianhi/ipympl/dblclick

ianhi commented 2 years ago

Ok I'm out of ideas for fixing this error:

[webpack-cli] Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:67:19)
    at Object.createHash (node:crypto:130:10)
    at BulkUpdateDecorator.hashFactory (/home/runner/work/ipympl/ipympl/node_modules/webpack/lib/util/createHash.js:155:18)
    at BulkUpdateDecorator.digest (/home/runner/work/ipympl/ipympl/node_modules/webpack/lib/util/createHash.js:80:21)
    at /home/runner/work/ipympl/ipympl/node_modules/webpack/lib/DefinePlugin.js:595:38
    at _next31 (eval at create (/home/runner/work/ipympl/ipympl/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:42:1)
    at _next9 (eval at create (/home/runner/work/ipympl/ipympl/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:97:1)
    at Hook.eval [as call] (eval at create (/home/runner/work/ipympl/ipympl/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:119:1)
    at Hook.CALL_DELEGATE [as _call] (/home/runner/work/ipympl/ipympl/node_modules/tapable/lib/Hook.js:14:14)
    at Compiler.newCompilation (/home/runner/work/ipympl/ipympl/node_modules/webpack/lib/Compiler.js:1053:26) {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

@martinRenou any thoughts? Everything on the internet seems to point this being an issue with node 17 but above commits moving to node 16 didn't seem to help :(

ianhi commented 2 years ago

bumping webpack version was the solution

ianhi commented 2 years ago

@nvaytet will release soon hopefully - going to try to work out whats happening with #416 first

martinRenou commented 2 years ago

Sorry I missed your question. I will push a PR for that OpenSSL issue, we fixed it in multiple places.

nvaytet commented 2 years ago

@ianhi awesome! thanks :-)