search

matplotlib / ipympl

Matplotlib Jupyter Integration
https://matplotlib.org/ipympl/
BSD 3-Clause "New" or "Revised" License
1.59k stars 225 forks source link

Fix OpenSSL issue #450

Closed martinRenou closed 2 years ago

martinRenou commented 2 years ago

cc. @ianhi

github-actions[bot] commented 2 years ago

Binder :point_left: Launch a binder notebook on branch _martinRenou/ipympl/opensslissue

ianhi commented 2 years ago

Is this a better fix than https://github.com/matplotlib/ipympl/commit/1e110c9b9cf5f5aefc94a5694a8c652a4af65699 ? If so should we revert that webpack requirement?

martinRenou commented 2 years ago

Sorry I missed your commit and went a bit fast opening a PR.

I actually prefer your fix, it's a lot better IMO. Now I should apply your fix everywhere I applied this workaround... 😄