matplotlib / ipympl

Matplotlib Jupyter Integration
https://matplotlib.org/ipympl/
BSD 3-Clause "New" or "Revised" License
1.59k stars 225 forks source link

NPM Relase action broken #458

Open ianhi opened 2 years ago

ianhi commented 2 years ago

There seem to be two issues:

  1. jupyterlab is not installed for the npm section
$ jupyter labextension build --development True .
/bin/sh: 1: jupyter: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
  1. Some sort of issue with NPM keys
npm notice 
npm ERR! code ENEEDAUTH
npm ERR! need auth This command requires you to be logged in to https://registry.npmjs.org/
npm ERR! need auth You need to authorize this machine using `npm adduser`

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2022-04-13T18_03_18_823Z-debug-0.log
Error: Process completed with exit code 1.

1 is an easy fix, we just need to pip install jupyterlab

  1. I think will require intervention from @tacaswell or someone else with the power mess around with repo secrets
ianhi commented 2 years ago

There may be some hints for 2 here: https://sergiodxa.com/articles/github-actions-npm-publish

possible using --access public and maybe specifying the registry

ianhi commented 2 years ago

For now I manually publish version 0.11.0

martinRenou commented 2 years ago

We could probably adopt jupyter-releaser and remove the action

tacaswell commented 2 years ago

@ianhi Email me so we can coordinate on what secrets need to be where.

ianhi commented 1 year ago

Just ran into this again with 0.11.3 https://github.com/matplotlib/ipympl/actions/runs/4187384014/jobs/7257141068

And by coming back here realized that I never followed up... though looking again im not sure that the secrets need to be updated? they're already present

ax3l commented 1 year ago

As a follow-up to #416, was this fixed already? :)

Wondering if I still need to match our user-side ipympl versions in kernels when running on HPC-center provided Jupyter instances.