Closed anntzer closed 2 years ago
Makes sense to me. Thanks for updating here as you go on the main repo :)
Only concern is the visual regression test failing. Maybe arestart will help
@ianhi AFAICT the same visual regression test also failed previously with https://github.com/matplotlib/ipympl/actions/runs/2333504817?
For reference, _Backend_ipympl.show is effectively the function that pyplot.show calls (pyplot.show even copies the signature of the backend show).
In af699c2, a 'close' kwarg was added to _Backend_ipympl.show, although any use of it was immediately removed in a subsequent commit (783419b). Still, this change means that calling e.g.
plt.show(True)
, for example, would no longer setblock=True
, but instead setclose=True
. As the change is relatively recent, it seems better to remove the unused 'close' kwarg again, which also makes the signature consistent with the builtin Matplotlib backends.