matplotlib / ipympl

Matplotlib Jupyter Integration
https://matplotlib.org/ipympl/
BSD 3-Clause "New" or "Revised" License
1.59k stars 225 forks source link

Remove unused 'close' arg to show(). #466

Closed anntzer closed 2 years ago

anntzer commented 2 years ago

For reference, _Backend_ipympl.show is effectively the function that pyplot.show calls (pyplot.show even copies the signature of the backend show).

In af699c2, a 'close' kwarg was added to _Backend_ipympl.show, although any use of it was immediately removed in a subsequent commit (783419b). Still, this change means that calling e.g. plt.show(True), for example, would no longer set block=True, but instead set close=True. As the change is relatively recent, it seems better to remove the unused 'close' kwarg again, which also makes the signature consistent with the builtin Matplotlib backends.

github-actions[bot] commented 2 years ago

Binder :point_left: Launch a binder notebook on branch anntzer/ipympl/unclose

ianhi commented 2 years ago

Makes sense to me. Thanks for updating here as you go on the main repo :)

Only concern is the visual regression test failing. Maybe arestart will help

anntzer commented 2 years ago

@ianhi AFAICT the same visual regression test also failed previously with https://github.com/matplotlib/ipympl/actions/runs/2333504817?