search

matplotlib / ipympl

Matplotlib Jupyter Integration
https://matplotlib.org/ipympl/
BSD 3-Clause "New" or "Revised" License
1.57k stars 227 forks source link

Fixup CI #514

Closed martinRenou closed 1 year ago

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a binder notebook on branch _martinRenou/ipympl/fixupci

martinRenou commented 1 year ago

update galata references

ianhi commented 1 year ago

is it possible to easily look at the differences in the generated images? I suspect that were catching a styling change in matplotlib latest

martinRenou commented 1 year ago

You can download the test artifacts on this page https://github.com/matplotlib/ipympl/actions/runs/4122954626 (bottom of the page -> ui-test-output file). It will contain the expected image, the actual image and the diff.

There seems to be a slight difference in the font rendering of the axis labels.

I suspect that were catching a styling change in matplotlib latest

Yes, I was thinking the same. It seems to only happen on Ubuntu.

Because it's a very slight difference I tried to change the threshold for the diff, without success.

ianhi commented 1 year ago

Yes, I was thinking the same. It seems to only happen on Ubuntu.

I think that there have been a bunch of changes to the font system recently. I almost wonder if this is surfacing a very subtle bug upstream

ianhi commented 1 year ago

@martinRenou what do you think about merging this now and fixing up the ubuntu latest in the future? As it stands this allows us to run tests, which we otherwise cant. which would be helpful for https://github.com/matplotlib/ipympl/pull/517 and https://github.com/matplotlib/ipympl/pull/478

martinRenou commented 1 year ago

That's fine with me, half working CI is better than non working one