search

matplotlib / ipympl

Matplotlib Jupyter Integration
https://matplotlib.org/ipympl/
BSD 3-Clause "New" or "Revised" License
1.57k stars 227 forks source link

release failed #518

Closed ianhi closed 1 year ago

ianhi commented 1 year ago

looks like the 0.9.3 release didn't actually make it through

https://github.com/matplotlib/ipympl/actions/runs/4186860606 I think we need

with:
   environment-file: false

we should add some words to the RELEASE.md for what to do in this case

tacaswell commented 1 year ago

well, on the bright side this means re-doing it will be picked up by zenodo!

ianhi commented 1 year ago

fixed the micromamba errors with: https://github.com/matplotlib/ipympl/commit/a39a31cc7c0799f6d8c83f82a12a9a09a6670e0d and have changes to the release doc

ianhi commented 1 year ago

npm failed: https://github.com/matplotlib/ipympl/issues/458

but I manually released that

ianhi commented 1 year ago

@martinRenou have you been manually updating the conda-forge on releases? Seems that way from: https://github.com/conda-forge/ipympl-feedstock/pulls?q=is%3Apr+is%3Aclosed

is there anything we need to do to make the magic bot make the PRs?

martinRenou commented 1 year ago

Thanks for fixing the action for releases!

have you been manually updating the conda-forge on releases?

Yes I sometimes do manual releases if I don't want to wait for the bot. We don't have to do anything for the bot to make PRs https://github.com/conda-forge/ipympl-feedstock/pull/65, we just need to wait a bit.

stevejpurves commented 1 year ago

seems like 0.9.3 is now out and this can be closed?

martinRenou commented 1 year ago

Thanks!