search

matplotlib / ipympl

Matplotlib Jupyter Integration
https://matplotlib.org/ipympl/
BSD 3-Clause "New" or "Revised" License
1.59k stars 225 forks source link

Update binder2 #555

Closed ianthomas23 closed 6 months ago

ianthomas23 commented 6 months ago

Update the binder config, both in the top of the README and in the github actions PR workflow. Take 2.

ianthomas23 commented 6 months ago

Here is the mybinder link that the README will effectively point to (but it will be on main rather than this PR branch): https://mybinder.org/v2/gh/ianthomas23/ipympl/update-binder2?urlpath=lab/tree/docs/examples/full-example.ipynb. It all seems to work OK.

It appears that the binder workflow is using the github action from main rather than this branch so it won't work until this is merged. I am happy to merge and iterate.

martinRenou commented 6 months ago

Thanks for looking into it!