search

matplotlib / mpl-brochure-site

Source for the top-level landing page.
Other
3 stars 13 forks source link

Add a 404 page #45

Closed QuLogic closed 2 years ago

QuLogic commented 2 years ago

On the new server, there is no default 404 page, which results in an empty document if navigating to an invalid URL. This generates a 404 page using our page CSS, so that it fits into the rest of the site better.

This also tweaks the layout so that the footer is forced to the bottom even for small pages (like the 404 page).

QuLogic commented 2 years ago

Example 404 page is here, but for some reason it didn't render right.

QuLogic commented 2 years ago

Ah, the CSS and JavaScript references are absolute (because the 404 page might be served from anywhere), but they aren't in that location on the CircleCI S3 server. I'm not sure if I can force those references to use the full domain too.

QuLogic commented 2 years ago

I'm not sure if I can force those references to use the full domain too.

OK, so I can't because the notfound extension forces the references to be absolute. Probably should be a feature request for them.