search

matplotlib / mpl-brochure-site

Source for the top-level landing page.
Other
3 stars 13 forks source link

search on homepage #50

Closed story645 closed 1 year ago

story645 commented 2 years ago

Can we add a search bar in the upper right corner (or really anywhere?) - I get the concerns about clutter, but lately 99% of my interactions have been homepage->docs->search 'cause I keep forgetting that there's no search on the homepage. image

timhoffm commented 2 years ago

If possible, I'd prefer that the search bar is in the same position for the cover page (https://matplotlib.org/) and for the individual doc pages.

Since the cover page has no sidebar, it would be reasonable to put it in the navbar (if there is enough space). It looks like the pydata-sphinx-theme has an option for that. IMHO that should be the first thing to check.

story645 commented 2 years ago

Agree, and that would mean a PR on https://github.com/matplotlib/mpl-sphinx-theme but not sure if I should transfer this issue there so I added it to the call agenda

jklymak commented 2 years ago

Isn't the search bar just a conf.py option? But I'm not sure the front page has a sidebar at all.

story645 commented 2 years ago

Yup, but if I change the configuration than the search bar location will change on all the pages. As far as I know the front page doesn't have a sidebar and that's why it doesn't have a search bar.

timhoffm commented 2 years ago

The front page has no sidebar. IMHO we should do this:

Move the search bar to the navbar everywhere using the above mentioned option. This is a already a config option of mpl-sphinx-theme, so does not need any change/PR on their side.

AFAICS this could be done in the same way on our normal docs and the brochure site.

timhoffm commented 2 years ago

Style: The search field should be on the right next to the link icons. For this the version switcher should be moved next to the logo, its dev entry should be shortened.

Current: grafik

Suggested: grafik