search

matplotlib / mpl-brochure-site

Source for the top-level landing page.
Other
3 stars 13 forks source link

Added meeting calendar under resources #51

Closed noatamir closed 2 years ago

noatamir commented 2 years ago

👋

  1. I added the meeting calendar under resources, highlighting the new contributor meeting.
  2. I wasn't able to preview the CSS locally so please let me know if I added the fa-icon correctly or not.
  3. I also tweaked the text for Gitter to be more inline with what we have in the README on github. Let me know if you'd like me to revert that.
  4. I put those to together. I thought the order made sense because the first 3 are for all project users, and the last 2 are relevant for those interested specifically in contributing to the project.
QuLogic commented 2 years ago

Can you rebase now that #53 is in? Circle doesn't build merges, unfortunately.

QuLogic commented 2 years ago

It looks like the icon is not working? image

It's FontAwesome v5; I think you might have used a v6 icon name. It probably needs the callout__icon style applied as well.

QuLogic commented 2 years ago

Oops, I forgot to put callout__icon in my suggested change.

noatamir commented 2 years ago

I can fix it 😉

noatamir commented 2 years ago

LGTM now. Thanks for the assist 😃

noatamir commented 2 years ago

(some day we should make all these links open in new tabs right?!)

jklymak commented 2 years ago

(some day we should make all these links open in new tabs right?!)

I would be pretty strenuously against that. I don't think we should force users to open tabs, and all browsers have a keyboard shortcuts to open in new tab if the user wishes. The only time it makes sense to open a new tab is if navigating a way will destroy the state of a page, which is definitely not the case for our home page.

jklymak commented 2 years ago

BTW I squash merged this....