Closed noatamir closed 2 years ago
Can you rebase now that #53 is in? Circle doesn't build merges, unfortunately.
It looks like the icon is not working?
It's FontAwesome v5; I think you might have used a v6 icon name. It probably needs the callout__icon
style applied as well.
Oops, I forgot to put callout__icon
in my suggested change.
I can fix it 😉
LGTM now. Thanks for the assist 😃
(some day we should make all these links open in new tabs right?!)
(some day we should make all these links open in new tabs right?!)
I would be pretty strenuously against that. I don't think we should force users to open tabs, and all browsers have a keyboard shortcuts to open in new tab if the user wishes. The only time it makes sense to open a new tab is if navigating a way will destroy the state of a page, which is definitely not the case for our home page.
BTW I squash merged this....
👋
fa-icon
correctly or not.