FIX: allow for non-github repos

matplotlib / mpl-third-party

Third-party Packages Webpage

https://matplotlib.org/mpl-third-party/

53 stars 71 forks source link

FIX: allow for non-github repos #100

Closed jklymak closed 1 year ago

jklymak commented 2 years ago

PR Summary

This now allows packages that do not have a GitHub repo to mostly work. They still need at least a pipit page.

The code is a bit tacky, so criticism most welcome.

jklymak commented 2 years ago

closes #91 as well...

tfardet commented 1 year ago

I'm not sure what's the rationale for requiring an empty repo if the tool is not on GitHub.

Why not simply replace the "github" tag by a "git", "code", or "repo" tag and just use whatever URL was provided in the PR?

What's the point of getting the user and package names from repo?

timhoffm commented 1 year ago

What's the point of getting the user and package names from repo?

None. The first version of this was written to quickly generate a basic output. It's not rigorously designed and contains some simplified assumptions.

The correct way forward is:

rename the github badge to repo (or code)
make the repo key in the YAML accept full URLs and
- either expand the pattern user/name to https://github.com/user/name for backward compatibility
- or convert all entries

You are welcome to open a PR.

tfardet commented 1 year ago

@jklymak do you plan to reopen a new PR or should I do it?

jklymak commented 1 year ago

No I don't plan to reopen this

timhoffm commented 1 year ago

Superseeded by #156.