search

matplotlib / mpl-third-party

Third-party Packages Webpage
https://matplotlib.org/mpl-third-party/
53 stars 70 forks source link

FIX: support URL to any forge #156

Closed tfardet closed 1 year ago

tfardet commented 1 year ago

Fixes #92 by accepting any URL in the repo field.

tfardet commented 1 year ago

I agree that current state is suboptimal, I could add a regex check in this PR and raise an error if regex fails and repo is a URL until we fix this, if you want.

QuLogic commented 1 year ago

You can add the regex to the schema, which should be caught by pre-commit.

timhoffm commented 1 year ago

You can add the regex to the schema, which should be caught by pre-commit.

This does not help here. The name parameter should still be free text. But we can only try to infer the repo name from it if it's format is more restricted.

QuLogic commented 1 year ago

Thanks @tfardet! Congratulations on your first PR to Matplotlib :tada: We hope to hear from you again.