search

matplotlib / mpl_mac_testing

Configuration for testing matplotlib on Mac OS-X using Travis
0 stars 5 forks source link

fix syntax for global/matrix env vars #8

Closed mrterry closed 11 years ago

mrterry commented 11 years ago

Fixes syntax in .travis.yml for global env vars and separated elements in the build matrix. Makes progress to getting uploaded tests working (#1)

mdboom commented 11 years ago

Thanks... sorry I messed it up. YAML syntax confuses the heck out of me :wink:

mrterry commented 11 years ago

It took me a couple tries to get it right. Are images being uploaded when a test fails? I'm not sure where to look for those. On Sep 16, 2013 9:48 AM, "Michael Droettboom" notifications@github.com wrote:

Thanks... sorry I messed it up. YAML syntax confuses the heck out of me [image: :wink:]

— Reply to this email directly or view it on GitHubhttps://github.com/matplotlib/mpl_mac_testing/pull/8#issuecomment-24525250 .

mdboom commented 11 years ago

The URL echoed at the end (when tests fail) should point to something valid. It doesn't look like (from doing a directory listing) that any of the tests in mpl_mac_testing have ever uploaded anything successfully, however.

On Mon, Sep 16, 2013 at 2:24 PM, Matt Terry notifications@github.comwrote:

It took me a couple tries to get it right. Are images being uploaded when a test fails? I'm not sure where to look for those. On Sep 16, 2013 9:48 AM, "Michael Droettboom" notifications@github.com wrote:

Thanks... sorry I messed it up. YAML syntax confuses the heck out of me [image: :wink:]

— Reply to this email directly or view it on GitHub< https://github.com/matplotlib/mpl_mac_testing/pull/8#issuecomment-24525250>

.

— Reply to this email directly or view it on GitHubhttps://github.com/matplotlib/mpl_mac_testing/pull/8#issuecomment-24532316 .

|\/|o | . | | ._ ||| . | ||(| |(|(/| |/|()(/| ||)()()| | |

http://www.droettboom.com/

mdboom commented 11 years ago

In order to be sure, I think we need to artificially introduce a failing result in to master -- the uploading doesn't work on pull requests, for security reasons.

On Mon, Sep 16, 2013 at 2:27 PM, Michael Droettboom mdboom@gmail.comwrote:

The URL echoed at the end (when tests fail) should point to something valid. It doesn't look like (from doing a directory listing) that any of the tests in mpl_mac_testing have ever uploaded anything successfully, however.

On Mon, Sep 16, 2013 at 2:24 PM, Matt Terry notifications@github.comwrote:

It took me a couple tries to get it right. Are images being uploaded when a test fails? I'm not sure where to look for those. On Sep 16, 2013 9:48 AM, "Michael Droettboom" notifications@github.com wrote:

Thanks... sorry I messed it up. YAML syntax confuses the heck out of me [image: :wink:]

— Reply to this email directly or view it on GitHub< https://github.com/matplotlib/mpl_mac_testing/pull/8#issuecomment-24525250>

.

— Reply to this email directly or view it on GitHubhttps://github.com/matplotlib/mpl_mac_testing/pull/8#issuecomment-24532316 .

|\/|o | . | | ._ ||| . | ||(| |(|(/| |/|()(/| ||)()()| | |

http://www.droettboom.com/

|\/|o | . | | ._ ||| . | ||(| |(|(/| |/|()(/| ||)()()| | |

http://www.droettboom.com/

mrterry commented 11 years ago

I had not thought much about security. That makes sense. If you think the keys are properly set up, I'll just keep an eye out for a failed test.

mdboom commented 11 years ago

Yeah -- I hadn't thought much about security either :wink:. Github just forcibly disallows it (by not properly decoding the encrypted variables on pull requests).