search

matprec / rust-font-loader

A font loading utility written in rust.
MIT License
52 stars 19 forks source link

Bump core-text dependency to 6.0 #9

Closed staktrace closed 7 years ago

staktrace commented 7 years ago

This is helpful to avoid core-text version conflicts in servo/webrender#1409, which depends on rust-font-loader. The changes between core-text 5.0 and 6.0 are trivial - the only change is the addition of a feature in the Cargo.toml file that allows opting out of OS X 10.8+-only APIs.

staktrace commented 7 years ago

r? @MSleepyPanda

matprec commented 7 years ago

Sorry for the delay! Normally i'd prefer a 0.x version change, since it is a major dependency version upgrade. Nevertheless LGTM in this particular case, since the upgrade from 5.0 to 6.0 is trivial. Thanks!

staktrace commented 7 years ago

@MSleepyPanda thanks for merging! And yeah I agree - if it had been a non-trivial change the 0.x version bump would have been better.

Could you also publish the new version to crates.io? Thanks!

matprec commented 7 years ago

@staktrace Done

staktrace commented 7 years ago

Thanks!