matricks / bam

Bam is a fast and flexible build system. Bam uses Lua to describe the build process. It's takes its inspiration for the script files from scons. While scons focuses on being 100% correct when building, bam makes a few sacrifices to acquire fast full and incremental build times.
http://matricks.github.com/bam
Other
146 stars 47 forks source link

is lua5.1 still supported? #110

Closed etosan closed 7 years ago

etosan commented 7 years ago

I would like to ask whether lua 5.1/luajit are still valid targets.

If yes, I am having issues compiling against 5.1 :

rc/main.c: In function 'register_lua_globals':
src/main.c:411:2: warning: implicit declaration of function 'lua_pushglobaltable' [-Wimplicit-function-declaration]
  lua_pushglobaltable(lua);
  ^~~~~~~~~~~~~~~~~~~
src/main.c:490:10: error: too many arguments to function 'lua_load'
    ret = lua_load(lua, internal_base_reader, (void *)&p, internal_files[f].filename, NULL);
          ^~~~~~~~
In file included from src/main.c:12:0:
/usr/include/lua5.1/lua.h:204:16: note: declared here
 LUA_API int   (lua_load) (lua_State *L, lua_Reader reader, void *dt,

I guess this is due to lua 5.1 -> lua 5.3 api change. Bam worked well for what I used it, so I missed update to 5.0, and I am now clueless whether lua 5.1 was dropped or not.

matricks commented 7 years ago

No, with 0.5.0 and forward, Lua 5.3 is required.

etosan commented 6 years ago

thanks